chore: rename roles toggles to flag #7123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sjaanus
commented
May 23, 2024
| @@ -110,6 +110,9 @@ test('Favor permission name over id migration correctly assigns permissions by n | |||
| { role_id: 101, permission: 'TEST_PERMISSION_4' }, | |||
| ]); | |||
|
|
|||
| // Run the toggle to flag update migration | |||
| await dbm.up('20240523113322-roles-toggle-to-flag-rename.js'); | |||
There was a problem hiding this comment.
This test is manually applying migrations and it was previously running old names. Now I apply the new naming migration to clean it up.
sjaanus
commented
May 23, 2024
| @@ -32,7 +32,7 @@ describe('feature', () => { | |||
| it('gives an error if a toggle exists with the same name', () => { | |||
| cy.createFeature_UI(featureToggleName, false, projectName); | |||
| cy.get("[data-testid='INPUT_ERROR_TEXT']").contains( | |||
| 'A toggle with that name already exists', | |||
| 'A flag with that name already exists', | |||
There was a problem hiding this comment.
Fixing an failing test.
kwasniew
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running migration to update roles descriptions.